Repository navigation
Treat "0" as a valid string - #311
Merged
Merged
Conversation
This was referenced Nov 17, 2026
swissspidy
marked this pull request as ready for review
November 17, 2026 16:28
swissspidy
force-pushed
the
fix/zero-strings
branch
from
November 18, 2026 12:59
2fe1aff to
011dfe3
Compare
Strings were checked for truthiness in several places, so "0" was handled like an empty string: * The PO loader dropped untranslated entries with `msgid "0"`. * The PO generator wrote `msgstr ""` for a "0" translation and left out a "0" context, plural or previous string. * The MO generator skipped entries translated as "0", as well as a "0" context or plural. * `Translation::mergeWith()` replaced a "0" translation or plural with the other one, and ignored them when overriding.
swissspidy
force-pushed
the
fix/zero-strings
branch
from
November 18, 2026 14:50
011dfe3 to
853d887
Compare
oscarotero
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strings were checked for truthiness in several places, so "0" was handled like an empty string:
msgid "0".msgstr ""for a "0" translation and left out a "0" context, plural or previous string.Translation::mergeWith()replaced a "0" translation or plural with the other one, and ignored them when overriding.See #312 for the Rector failures
Claude-Session: https://claude.ai/code/session_01UWTd5qmztfFv37ybV4xsjV